Skip to content

feat: Add tag for deprecated endpoints#1524

Closed
ZohebShaikh wants to merge 2 commits intomainfrom
blueapi-tags
Closed

feat: Add tag for deprecated endpoints#1524
ZohebShaikh wants to merge 2 commits intomainfrom
blueapi-tags

Conversation

@ZohebShaikh
Copy link
Copy Markdown
Contributor

No description provided.

@ZohebShaikh ZohebShaikh requested a review from a team as a code owner April 28, 2026 13:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (74bbcf0) to head (83bbd3b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1524   +/-   ##
=======================================
  Coverage   95.30%   95.31%           
=======================================
  Files          43       43           
  Lines        3198     3199    +1     
=======================================
+ Hits         3048     3049    +1     
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw
Copy link
Copy Markdown
Contributor

tpoliaw commented Apr 28, 2026

What is the benefit of adding this as a tag? As far as I can see, with the Deprecated tag, the endpoints lose their grouping on the docs page and get bundled into one group at the end. Without the tag (but with the existing deprecated=True flag), the endpoints are in their original groups but greyed out. In the openapi schema, the old endpoints already have a deprecated=true field so the tag doesn't really add anything there.

@ZohebShaikh
Copy link
Copy Markdown
Contributor Author

I personally feel that it looks neater to see the docs page like that.

I'm not fussed about it. Will close the PR

@ZohebShaikh ZohebShaikh deleted the blueapi-tags branch April 28, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants